Use SwiftSyntax:: prefix for SwiftSyntax #7498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We actually want it to be the same as other clients that might use both SwiftSyntax and SwiftPM, such as SourceKit-LSP.
DougGregor
requested review from
bnbarham,
MaxDesiatov and
tomerd
as code owners
|
@swift-ci please test |
|
@swift-ci test windows |
|
It's unclear whether we need this given swiftlang/swift-syntax#2628 and #7505 |
|
Closing this out! We don't need it with the other planned changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually want it to be the same as other clients that might use both SwiftSyntax and SwiftPM, such as SourceKit-LSP.