Skip to content

Cleanup addition of swift-syntax #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

bnbarham
Copy link
Contributor

No description provided.

@bnbarham
Copy link
Contributor Author

swiftlang/swift#73267

@swift-ci please test

@bnbarham bnbarham force-pushed the swift-syntaxify-round-2 branch from b12b5c4 to 1b97c6a Compare April 26, 2024 02:41
@bnbarham
Copy link
Contributor Author

swiftlang/swift#73267

@swift-ci please test

@bnbarham bnbarham force-pushed the swift-syntaxify-round-2 branch from 1b97c6a to 034b1c9 Compare April 26, 2024 03:31
@bnbarham
Copy link
Contributor Author

swiftlang/swift#73267

@swift-ci please test

@bnbarham bnbarham force-pushed the swift-syntaxify-round-2 branch from 034b1c9 to 4fc925f Compare April 26, 2024 05:07
@bnbarham bnbarham changed the title Do not export swift-syntax Cleanup addition of swift-syntax Apr 26, 2024
@bnbarham
Copy link
Contributor Author

@bnbarham
Copy link
Contributor Author

swiftlang/swift-syntax#2628

@swift-ci please test

@bnbarham
Copy link
Contributor Author

swiftlang/swift-syntax#2628

@swift-ci please clean test

@bnbarham
Copy link
Contributor Author

swiftlang/swift-syntax#2628

@swift-ci please clean test Windows platform

1 similar comment
@bnbarham
Copy link
Contributor Author

swiftlang/swift-syntax#2628

@swift-ci please clean test Windows platform

@bnbarham bnbarham force-pushed the swift-syntaxify-round-2 branch from 41c0836 to b6ad32e Compare April 27, 2024 04:51
@bnbarham
Copy link
Contributor Author

swiftlang/swift-syntax#2628

@swift-ci please test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@DougGregor
Copy link
Member

swiftlang/swift-syntax#2628

@swift-ci please test Windows

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be passing everywhere, woo-hoo!

@DougGregor
Copy link
Member

Just waiting on swiftlang/swift-syntax#2628 to merge first

@DougGregor DougGregor merged commit ecf2e8f into swiftlang:main Apr 27, 2024
5 checks passed
@bnbarham bnbarham deleted the swift-syntaxify-round-2 branch April 27, 2024 19:49
ahoppen pushed a commit to ahoppen/swift-package-manager that referenced this pull request May 2, 2024
ahoppen added a commit that referenced this pull request May 3, 2024
- **Explanation**: Cherry-pick the following to PRs which are companions
of swiftlang/sourcekit-lsp#1213
  - #7505
  - #7492
- **Scope**: CMake build and SourceKit-LSP API
- **Risk**: Low, the SourceKit-LSP API is only used by SourceKit-LSP and
the CMake build changes will all be caught at build-time
- **Testing**: n/a
- **Issue**: n/a
- **Reviewer**: @DougGregor and @MaxDesiatov on
#7505 and
#7492

---------

Co-authored-by: Ben Barham <[email protected]>
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants