Add back --enable-experimental-swift-testing to swift build as a no-op.
#7817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no-op. For the benefit of the VSCode Swift plugin, we need to keep this flag around (but as a no-op and hidden from documentation) until the plugin drops support for earlier Swift 6 prereleases. Resolves rdar://132408655.
grynspan
added
bug
swift test
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci please test |
MaxDesiatov
approved these changes
Jul 24, 2024
grynspan
changed the title
--enable-experimental-swift-testing to swift build as a no-op.--enable-experimental-swift-testing to swift build as a no-op.
grynspan
added a commit
that referenced
this pull request
Jul 24, 2024
… as a no-op. (#7818) **Explanation:** Adds back some no-op arguments to `swift build` so that the VSCode plugin stays happy. **Scope:** Bug fix in `swift build`. **Issue:** rdar://132408655 **Original PR:** #7817 **Risk:** Low **Testing:** N/A (no-op arguments, they do nothing) **Reviewer:** @MaxDesiatov @bnbarham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the benefit of the VSCode Swift plugin, we need to keep this flag around (but as a no-op and hidden from documentation) until the plugin drops support for earlier Swift 6 prereleases.
Resolves rdar://132408655.