Skip to content

[6.0] Add back --enable-experimental-swift-testing to swift build as a no-op. #7818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

grynspan
Copy link
Contributor

Explanation: Adds back some no-op arguments to swift build so that the VSCode plugin stays happy.
Scope: Bug fix in swift build.
Issue: rdar://132408655
Original PR: #7817
Risk: Low
Testing: N/A (no-op arguments, they do nothing)
Reviewer: @MaxDesiatov @bnbarham

… no-op.

For the benefit of the VSCode Swift plugin, we need to keep this flag around
(but as a no-op and hidden from documentation) until the plugin drops support
for earlier Swift 6 prereleases.

Resolves rdar://132408655.
@grynspan grynspan added bug swift test Changes impacting `swift test` tool swift build Changes impacting `swift build` labels Jul 24, 2024
@grynspan grynspan self-assigned this Jul 24, 2024
@grynspan grynspan requested a review from a team as a code owner July 24, 2024 16:10
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan grynspan changed the title [6.0] Add back `--enable-experimental-swift-testing to swift build as a no-op. [6.0] Add back --enable-experimental-swift-testing to swift build as a no-op. Jul 24, 2024
@grynspan grynspan enabled auto-merge (squash) July 24, 2024 18:07
@grynspan grynspan merged commit 04c01f6 into release/6.0 Jul 24, 2024
5 checks passed
@grynspan grynspan deleted the jgrynspan/132408655-test-library-build-flags-6.0 branch July 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug swift build Changes impacting `swift build` swift test Changes impacting `swift test` tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants