Tests: Enable BasicsTests/FileSystem/* Tests on Windows (Swift Testing) #8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/enable_more_windows_tests_gh8433_rdar148248105
branch
from
eba83b8 to
bcda027
Compare
|
@swift-ci test self hosted windows |
|
@swift-ci please test |
|
@swift-ci test windows |
|
@swift-ci test self hosted windows |
bkhouri
commented
Apr 4, 2025
There was a problem hiding this comment.
note: this was copied from IntegrationTests\Sources\IntegrationTestSupport
There was a problem hiding this comment.
This is introduced in #8476
There was a problem hiding this comment.
note: this was copied from IntegrationTests\Sources\IntegrationTestSupport
There was a problem hiding this comment.
This is introduced in #8476
bkhouri
added
windows
test suite
bkhouri
changed the title
bkhouri
changed the title
bkhouri
force-pushed
the
t/main/enable_more_windows_tests_gh8433_rdar148248105
branch
from
bcda027 to
6e1d9c4
Compare
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv and
cmcgee1024
as code owners
cmcgee1024
approved these changes
Apr 11, 2025
bkhouri
force-pushed
the
t/main/enable_more_windows_tests_gh8433_rdar148248105
branch
from
6e1d9c4 to
1e8687d
Compare
|
@swift-ci test |
|
@swift-ci test self hosted windows |
bkhouri
force-pushed
the
t/main/enable_more_windows_tests_gh8433_rdar148248105
branch
from
1e8687d to
b437931
Compare
bkhouri
commented
Apr 11, 2025
|
@swift-ci test |
|
@swift-ci test self hosted windows |
1 task
bkhouri
force-pushed
the
t/main/enable_more_windows_tests_gh8433_rdar148248105
branch
from
b437931 to
642e54c
Compare
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Also, to workaround a Build preset issue, add a dependency on Swift Testing when we are building using local dependencies. Related to: swiftlang#8433 rdar://148248105
Convert test from XCTest to Swift Testing. - Tests/BasicsTests/FileSystem/FileSystemTests.swift - Tests/BasicsTests/FileSystem/PathShimTests.swift - Tests/BasicsTests/FileSystem/PathTests.swift - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift - Tests/BasicsTests/FileSystem/VFSTests.swift relates to: swiftlang#8433
Enable more tests on Windows that are currently passing in Basics/FileSystem/*.swift Depends on: swiftlang#8448 Partially Addresses: swiftlang#8433 Issue: rdar://148248105
bkhouri
force-pushed
the
t/main/enable_more_windows_tests_gh8433_rdar148248105
branch
from
642e54c to
8754cfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert test from XCTest to Swift Testing, while updating to ensuring we mark the tests that currently fail on windows..
Tests/BasicsTests/FileSystem/FileSystemTests.swift
Tests/BasicsTests/FileSystem/PathShimTests.swift
Tests/BasicsTests/FileSystem/PathTests.swift
Tests/BasicsTests/FileSystem/TemporaryFileTests.swift
Tests/BasicsTests/FileSystem/VFSTests.swift
Depends on #8476
Partially Addresses: #8433
Issue: rdar://148248105