Add Syntax nodes for compiler generated files #2968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#79513 |
rintaro
force-pushed
the
compiler-generated-files
branch
from
75cb90a to
66c1a1e
Compare
rintaro
changed the title
|
swiftlang/swift#79513 |
* `AccessorBlockFileSyntax`: For `accessor` macro expansions
* `AttributeClauseFileSyntax`: For `memberAttribute` macro expansions
* `CodeBlockFileSyntax`: For `body` macro expansiosns
* `MemberBlockItemListFileSyntax`: For decl macros in type contexts
Also rename 'AvailabilityMacroDefinition' to
`AvailabilityMacroDefinitionFile` and add 'endOfFileToken'.
These are 'Compiler' SPI and parsed as a "file". To keep the source
fidelity, we should keep the EOF token which might have some trivia.
In `CodeGeneration`, make `collectionElementName` optional to avoid
unnecessary _deprecated_ `add{ElemebtName}(_:)` methods.
rintaro
force-pushed
the
compiler-generated-files
branch
from
66c1a1e to
7549913
Compare
|
swiftlang/swift#79513 |
|
swiftlang/swift#79513 |
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Linux |
ahoppen
approved these changes
Feb 22, 2025
Comment on lines
+13
to
+17
| #if compiler(>=6) | ||
| @_spi(RawSyntax) @_spi(ExperimentalLanguageFeatures) internal import SwiftSyntax | ||
| #else | ||
| @_spi(RawSyntax) @_spi(ExperimentalLanguageFeatures) import SwiftSyntax | ||
| #endif |
There was a problem hiding this comment.
Why do you need internal import here?
There was a problem hiding this comment.
Not sure I understand your question. Every swift files in SwiftParser has internal import SwiftSyntax or public import SwiftSyntax depending on the APIs declared in the file.
There was a problem hiding this comment.
Ooops, I thought that we didn’t use scoped imports at all in swift-syntax. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All 'Compiler' SPI.
These are parsed as "file". To keep the source fidelity, we should keep the EOF token which might have some trivia.
AccessorBlockFileSyntax: Foraccessormacro expansionsAttributeClauseFileSyntax: FormemberAttributemacro expansionsCodeBlockFileSyntax: Forbodymacro expansiosnsMemberBlockItemListFileSyntax: For decl macros in type contextsAvailabilityMacroDefinitiontoAvailabilityMacroDefinitionFileand addendOfFileToken.In
CodeGeneration, makecollectionElementNameoptional to avoid unnecessary deprecatedadd{ElemebtName}(_:)methods.