[ASTGen] Fix expanded macro buffer parsing and AST generation #79513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
swiftlang/swift-syntax#2968 |
rintaro
commented
Feb 20, 2025
rintaro
force-pushed
the
astgen-macro-expanded-syntax
branch
2 times, most recently
from
16c9650 to
c302e79
Compare
|
swiftlang/swift-syntax#2968 |
1 similar comment
|
swiftlang/swift-syntax#2968 |
hamishknight
approved these changes
Feb 21, 2025
include/swift/AST/ASTBridging.h
Outdated
| @@ -1511,6 +1511,12 @@ enum ENUM_EXTENSIBILITY_ATTR(closed) BridgedOperatorFixity { | |||
| BridgedOperatorFixityPostfix, | |||
| }; | |||
|
|
|||
| SWIFT_NAME("BridgedMissingDecl.createParsed(_:declContext:loc:)") | |||
There was a problem hiding this comment.
Calling this createParsed doesn't feel right since the resulting decl is implicit, maybe just create, or createImplicit?
Parse expanded buffer into dedicated syntax. Also rename `BridgedGeneratedSourceFileKindAttribute` to `BridgedGeneratedSourceFileKindAttributeFromClang` because C++ decl (i.e. `GeneratedSourceInfo::Kind::AttributeFromClang`) was renamed a while ago.
rintaro
force-pushed
the
astgen-macro-expanded-syntax
branch
from
c302e79 to
aae50a8
Compare
|
swiftlang/swift-syntax#2968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse macro expanded buffers into the dedicated syntax.
Also rename
BridgedGeneratedSourceFileKindAttributetoBridgedGeneratedSourceFileKindAttributeFromClangbecause C++ decl (i.e.GeneratedSourceInfo::Kind::AttributeFromClang) was renamed a while ago.