Skip to content

Skipped tests have a runtime equal to the runtime of the entire test invocation #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakepetroules opened this issue Sep 29, 2024 · 0 comments · Fixed by #741
Closed

Skipped tests have a runtime equal to the runtime of the entire test invocation #740

jakepetroules opened this issue Sep 29, 2024 · 0 comments · Fixed by #741
Assignees
@grynspan
Labels
bug 🪲 Something isn't working tools integration Integration of swift-testing into tools/IDEs

Comments

@jakepetroules
Copy link

Description

I have a bunch of skipped tests which are reported as having "177 seconds" runtime. But if a test was skipped, it seems that its runtime should be counted as zero.

Expected behavior

No response

Actual behavior

No response

Steps to reproduce

No response

swift-testing version/commit hash

No response

Swift & OS version (output of swift --version ; uname -a)

No response
@jakepetroules jakepetroules added the bug 🪲 Something isn't working label Sep 29, 2024
@grynspan grynspan self-assigned this Sep 29, 2024
@grynspan grynspan added the tools integration Integration of swift-testing into tools/IDEs label Sep 29, 2024
grynspan added a commit that referenced this issue Sep 30, 2024
@grynspan
Do not emit a time= attribute in JUnit output for skipped tests.
1c3321a 
Resolves #740.
@grynspan grynspan mentioned this issue Sep 30, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working tools integration Integration of swift-testing into tools/IDEs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not emit a time= attribute in JUnit output for skipped tests. swiftlang/swift-testing
2 participants
@jakepetroules @grynspan