Skip to content

Do not emit a time= attribute in JUnit output for skipped tests. #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2024
Merged

Do not emit a time= attribute in JUnit output for skipped tests. #741

merged 1 commit into from
Sep 30, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 30, 2024 •
edited
Loading

Resolves #740.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added bug 🪲 Something isn't working swiftpm-integration Swift Package Manager integration tools integration Integration of swift-testing into tools/IDEs labels Sep 30, 2024
@grynspan grynspan self-assigned this Sep 30, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit bd66853 into main Sep 30, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/740-xml-time-for-skipped branch September 30, 2024 16:32
@grynspan grynspan added this to the Swift 6.1 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working swiftpm-integration Swift Package Manager integration tools integration Integration of swift-testing into tools/IDEs
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.

Skipped tests have a runtime equal to the runtime of the entire test invocation
2 participants
@grynspan @stmontgomery