Suppress .unsafeFlags() in Package.swift when tagging for release.
#991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the unsafe flags we specify in our Package.swift manifest when the package has been tagged in Git (which indicates it's a release or prerelease.) This allows a package to add Swift Testing as a package dependency without breaking its own ability to be added as a package dependency due to the use of unsafe flags.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
stmontgomery
requested changes
Mar 3, 2025
|
@swift-ci test |
stmontgomery
approved these changes
Mar 3, 2025
grynspan
added a commit
that referenced
this pull request
Mar 3, 2025
…991) This PR removes the unsafe flags we specify in our Package.swift manifest when the package has been tagged in Git (which indicates it's a release or prerelease.) This allows a package to add Swift Testing as a package dependency without breaking its own ability to be added as a package dependency due to the use of unsafe flags. - [ ] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [ ] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Mar 3, 2025
…ease. (#993) - **Explanation**: Don't include `.unsafeFlags()` in Package.swift in tagged releases so that they can be used as package dependencies. - **Scope**: Anybody who wants to include Swift Testing as a package dependency rather than using the toolchain or Xcode copy. - **Issues**: N/A - **Original PRs**: #991 - **Risk**: Low (no obvious risk) - **Testing**: Tagged the branch locally and built. Build was successful. - **Reviewers**: @stmontgomery @briancroom
M7md-Ebrahim
reviewed
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unsafe flags we specify in our Package.swift manifest when the package has been tagged in Git (which indicates it's a release or prerelease.) This allows a package to add Swift Testing as a package dependency without breaking its own ability to be added as a package dependency due to the use of unsafe flags.
Checklist: