Skip to content

[6.1] Suppress .unsafeFlags() in Package.swift when tagging for release. #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Mar 3, 2025

  • Explanation: Don't include .unsafeFlags() in Package.swift in tagged releases so that they can be used as package dependencies.
  • Scope: Anybody who wants to include Swift Testing as a package dependency rather than using the toolchain or Xcode copy.
  • Issues: N/A
  • Original PRs: Suppress .unsafeFlags() in Package.swift when tagging for release. #991
  • Risk: Low (no obvious risk)
  • Testing: Tagged the branch locally and built. Build was successful.
  • Reviewers: @stmontgomery @briancroom

…991)

This PR removes the unsafe flags we specify in our Package.swift
manifest when the package has been tagged in Git (which indicates it's a
release or prerelease.) This allows a package to add Swift Testing as a
package dependency without breaking its own ability to be added as a
package dependency due to the use of unsafe flags.

- [ ] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [ ] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added bug 🪲 Something isn't working tools integration Integration of swift-testing into tools/IDEs embedded-swift 📟 Embedded Swift issues build 🧱 Affects the project's build configuration or process labels Mar 3, 2025
@grynspan grynspan added this to the Swift 6.1 milestone Mar 3, 2025
@grynspan grynspan self-assigned this Mar 3, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Mar 3, 2025

@swift-ci test

@grynspan grynspan merged commit 43b6f88 into release/6.1 Mar 3, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/suppress-unsafe-flags-in-release-6.1 branch March 3, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process embedded-swift 📟 Embedded Swift issues tools integration Integration of swift-testing into tools/IDEs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants