Added Swift Logo to the Readme #111
Conversation
|
Why not SVG? |
|
@krememek What do you prefer svg or png. Should I keep this in local swift repo ?? |
| @@ -1,3 +1,4 @@ | |||
|  | |||
There was a problem hiding this comment.
My preference would be to link to an asset from swift.org. The primary SVG should used as a the website header would probably work.
|
@krememek Done the changes. It's looking nice. Thanks |
|
@codestergit Great! However the logo is quite big. I just fixed the width in my pull request #113. |
|
@krememek Reduced height. Thanks @emilstahl for suggestion. :) |
|
@zachpanz88 It does not work. |
|
Suggestion removed as I believe GitHub does not support SVG images in markdown, but html will work. |
|
@emilstahl Yes it does, I just previewed it in the GitHub markdown preview. It does work. |
|
@zachpanz88 Did you see the code @zachpanz88 posted and then deleted? It clearly did not work when he tried to change the size in markdown. |
|
This code will work, but changing the size they way I originally did will not work, which was the error in the first version. Note: github does not support changing image size in their flavored markdown, but changing image size in html works. Output: |
|
@zachpanz88 You are right there is some problem with github markup we can not give the height. I have previously faced that issue. You need to add HTML for that. Thanks |
|
Really great! Looks good to me 👍 |
|
Looks great. |
Add support for extension declarations
[Data] fix crash when creating iterator of empty DispatchData
[Data] fix crash when creating iterator of empty DispatchData Signed-off-by: Daniel A. Steffen <[email protected]>
test: add a syntax parse round-trip test
UNXFAIL fixed SwiftLint SR-6349
We need this !!