Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swift logo with properly width to Readme (SVG from Swift.org) #113

Closed
wants to merge 1 commit into from

Conversation

emilstahl
Copy link

As suggested by @krememek in #111

@tkremenek
Copy link
Member

Can you squash this into a single commit?

@codestergit
Copy link
Contributor

@emilstahl Thanks for suggestion. I have reduced the height.

@emilstahl emilstahl force-pushed the master branch 3 times, most recently from dbc5b53 to 2eff183 Compare December 4, 2015 00:41
@emilstahl
Copy link
Author

@krememek Took some trial and error, but finally I managed to squash it into a single commit!

@emilstahl emilstahl changed the title Added Swift logo to Readme (SVG from Swift.org) Added Swift logo with properly width to Readme (SVG from Swift.org) Dec 4, 2015
@emilstahl emilstahl force-pushed the master branch 2 times, most recently from 71cca30 to a995597 Compare December 4, 2015 02:00
@@ -1,3 +1,4 @@
<img src="https://swift.org/assets/images/swift.svg" alt="Swift logo" width="200">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to just specify this in Markdown’s image format?

![Swift Logo](https://swift.org/assets/images/swift.svg)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattbischoff You can’t set the width in Markdown.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it.

@gribozavr
Copy link
Contributor

The readme seems to be using an SVG logo now.

@gribozavr gribozavr closed this Dec 11, 2015
kant added a commit to kant/swift that referenced this pull request Dec 14, 2017
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
leverage of new kevent timer granularity functionality
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
leverage of new kevent timer granularity functionality

Signed-off-by: Daniel A. Steffen <[email protected]>
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
[README] Add section on how to report issues
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants