Capitalize Swift in FoundationShims.h #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // coming in from two different Clang modules | ||
| // (rdar://problem/16294674). Instead, we copy the definitions here | ||
| // (rdar://problem/16294674). Instead, we copy the definitions here |
There was a problem hiding this comment.
It is customary to use two spaces to separate sentences.
There was a problem hiding this comment.
There are multiple opinions on this subject, but one convention is to insert two spaces after a full stop. Wikipedia summarizes viewpoints nicely: https://en.wikipedia.org/wiki/Sentence_spacing
There was a problem hiding this comment.
I see, but I don't think comments are best place for this convention, for me it doesn't feel right to see two sentences in one line, separated by too much space. Thanks for reply!
|
Please also use a more descriptive commit message. |
gribozavr
changed the title
|
Applied the capitalization in 3fb3853 |
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Nov 21, 2018
…ent-sigil Make CommentWhitespace a lint-only rule.
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
Ignore any files Xcode generates when the package is opened directly
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Adding 4.0 compatibility to AsyncNinja
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
Revert "Update Installer Scripts for sourcekit-lsp to Include SwiftSyntax"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.