Skip to content

Capitalize Swift in FoundationShims.h #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Capitalize Swift in FoundationShims.h #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/public/SwiftShims/FoundationShims.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@

//===--- Layout-compatible clones of Foundation structs -------------------===//
// Ideally we would declare the same names as Foundation does, but
// swift's module importer is not yet tolerant of the same struct
// Swift's module importer is not yet tolerant of the same struct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part LGTM.

// coming in from two different Clang modules
// (rdar://problem/16294674). Instead, we copy the definitions here
// (rdar://problem/16294674). Instead, we copy the definitions here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is customary to use two spaces to separate sentences.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple opinions on this subject, but one convention is to insert two spaces after a full stop. Wikipedia summarizes viewpoints nicely: https://en.wikipedia.org/wiki/Sentence_spacing

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, but I don't think comments are best place for this convention, for me it doesn't feel right to see two sentences in one line, separated by too much space. Thanks for reply!

// and then do horrible unsafeBitCast trix to make them usable where required.
//===----------------------------------------------------------------------===//

Expand Down