Fcntl extension #196
Fcntl extension #196
Conversation
|
Since this is a change to the library API, so it should follow the Swift Evolution Process. Please write an informal proposal and send it to [email protected]. For the PR itself, please clang-format the C sources, and add tests for the new APIs. |
gribozavr
added
the
swift evolution pending discussion
|
This document provides a thorough guide on submitting a proposal: https://github.com/apple/swift-evolution/blob/master/process.md |
…ay. Added tests for same. Fixed a few bug in the tests.
…reas on Apple OS's it's -1. Had logic reversed in new fcntl() expectXXXX() functions.
…onal to conform with other "C" library APIs.
| // Change modes on existing file. | ||
| POSIXTests.test("fcntl F_GETFL/F_SETFL success with file") { | ||
| // Create and open file. | ||
| system("touch \(fn)") |
There was a problem hiding this comment.
system() won't work on iOS, you need to create file manually.
There was a problem hiding this comment.
Ok, will make the change...
On Dec 10, 2015, at 1:40 PM, Dmitri Gribenko [email protected] wrote:
In test/1_stdlib/POSIX.swift #196 (comment):
@@ -78,6 +81,112 @@ POSIXSemaphore.test("sem_open existing O_EXCL fail") {
let res2 = sem_unlink(semaphoreName)
expectEqual(0, res2)
}+// Fail because file doesn't exist.
+POSIXTests.test("fcntl fail") {
- let fd = open(strdup(fn), 0)
- expectEqual(-1, fd)
- expectEqual(ENOENT, errno)
- let _ = fcntl(fd, F_GETFL)
- expectEqual(EBADF, errno)
+}
+// Change modes on existing file.
+POSIXTests.test("fcntl F_GETFL/F_SETFL success with file") {
- // Create and open file.
- system("touch (fn)")
system() won't work on iOS, you need to create file manually.—
Reply to this email directly or view it on GitHub https://github.com/apple/swift/pull/196/files#r47265320.
…he strdup() call that left over from earlier debugging.
|
All recommended changes complete and tested. |
| } | ||
|
|
||
| extern sem_t *_swift_Glibc_sem_open4(const char *name, int oflag, | ||
| mode_t mode, unsigned int value) { |
There was a problem hiding this comment.
Indentation seems to be off.
|
Could you squash everything into one commit and resolve conflicts against master? |
|
Sure. I'll close this and re-issue a new pull request with a single commit plus the merge as soon as I get it done. |
|
@billabt A new PR is not strictly necessary: https://help.github.com/articles/about-git-rebase/ |
build: add a cmake based build system
build: add a cmake based build system Signed-off-by: Daniel A. Steffen <[email protected]>
Fix spacing for binary operator overloads
[NFC] Cleanup argument parsing logic.
Remove realm configuration, doesn't work with sandbox
AnthonyLatsis
removed
the
swift evolution pending discussion
Restructure the packaging to be more homogeneous and concise.
- Swift Software Development Kit
* Swift Compiler Tools
* Swift Developer Tools
* Swift Windows Runtime (AMD64|ARM64|x86)
* Swift Windows SDK (AMD64|ARM64|x86)
This gives a more concise description that is also easier to understand
and map. This sets up the path for further refinement of the installer
to provide more control over the installed components.
We do not suffix the Software Development Kit nor Compiler and Developer
Tools as there will be a singular version that matches the host that is
installed. Therefore, there is no value in differentiating that.
However, multiple SDKs and Runtimes may be present, so identify the
architecture for them.
This pull request exposes the variadic fcntl() API to Swift for both OS X and Linux. It adds 3 different forms of the fcntl() API to the Swift stdlib. Tested on both OS X and Linux (Ubuntu 15.10).