Implementation of fcntl() to both Darwin and Glibc overlays. Ported … #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pen(), openat() and sem_open() from Darwin to Glibc. Added tests for new fcntl functionality.
| @@ -1,5 +1,6 @@ | |||
| set(sources | |||
| Glibc.swift | |||
| Glibc.swift | |||
| Misc.c | |||
There was a problem hiding this comment.
The indentation convention for cmake is 4 spaces for continuation lines.
|
LGTM with (mostly) formatting changes. It is unfortunate we don't have anything like |
|
This should be good to go now. Tested and working as expected. |
Closed
|
Tested on OS X and Ubuntu 14.04. |
gribozavr
added a commit
that referenced
this pull request
Dec 12, 2015
Implementation of fcntl() to both Darwin and Glibc overlays. Ported …
| public func open( | ||
| path: UnsafePointer<CChar>, | ||
| _ oflag: CInt | ||
| ) -> CInt { |
There was a problem hiding this comment.
Just wondering: why not use a default value of 0 for the mode: mode_t parameter instead of duplicating those functions?
There was a problem hiding this comment.
Because that's how the man page describes the function: there are three variants, one accepts void, another accepts a pointer, and another accepts int. It does not describe the void one as a variant of the int one.
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
SDK: guard BSD specific paths against windows
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Update run_cperf with 3 extra options needed by the build-script preset code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…open(), openat() and sem_open() from Darwin to Glibc. Added tests for new fcntl functionality.