Skip to content

[5.7] [Sema] Update regex capture decoding #59555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

[5.7] [Sema] Update regex capture decoding #59555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Sema/CSGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,7 +1301,7 @@ namespace {
ctx.Id_Regex.str());
return Type();
}
SmallVector<TupleTypeElt, 4> matchElements {ctx.getSubstringType()};
SmallVector<TupleTypeElt, 4> matchElements;
if (decodeRegexCaptureTypes(ctx,
E->getSerializedCaptureStructure(),
/*atomType*/ ctx.getSubstringType(),
Expand All @@ -1310,6 +1310,7 @@ namespace {
diag::regex_capture_types_failed_to_decode);
return Type();
}
assert(!matchElements.empty() && "Should have decoded at least an atom");
if (matchElements.size() == 1)
return BoundGenericStructType::get(
regexDecl, Type(), matchElements.front().getType());
Expand Down