Skip to content

[5.7] [Sema] Update regex capture decoding #59555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

[5.7] [Sema] Update regex capture decoding #59555

merged 1 commit into from
Jun 28, 2022

Conversation

milseman
Copy link
Member

Cherry-pick of #59506

@hamishknight @milseman
[Sema] Update regex capture decoding
3f6b6e8 
We now always expect to decode at least a
Substring for the whole capture.
@milseman milseman requested a review from a team as a code owner June 18, 2022 00:58
@milseman milseman requested a review from hamishknight June 18, 2022 00:58
@milseman
Copy link
Member Author

Needed for swiftlang/swift-experimental-string-processing#499

@milseman
Copy link
Member Author

swiftlang/swift-experimental-string-processing#499
@swift-ci please test

@milseman milseman mentioned this pull request Jun 18, 2022
Merged
@milseman milseman merged commit dfa1fe5 into swiftlang:release/5.7 Jun 28, 2022
@milseman milseman deleted the regex_capture_decoding branch June 28, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

@hamishknight hamishknight hamishknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milseman @stephentyrone @hamishknight