Allow local archetypes in interface types of local declarations #73570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing hasArchetype() is now deprecated. It is equivalent to:
hasPrimaryArchetype() || hasLocalArchetype()
Callers should be changed to check one or both of the above predicates
in the most precise way possible.
simanerush
reviewed
May 10, 2024
| @@ -9370,35 +9370,6 @@ static std::optional<PackIterationInfo> applySolutionToForEachStmt( | |||
| std::optional<SyntacticElementTarget>(SyntacticElementTarget)> | |||
| rewriteTarget) { | |||
|
|
|||
| // A special walker to record opened element environment for var decls in a | |||
| // for-each loop. | |||
| class Walker : public ASTWalker { | |||
There was a problem hiding this comment.
Thank you for getting rid of this!👏🏻
We don't need to build a DenseMap here. More importantly, this changes the logic to avoid calling mapTypeOutOfContext() on element archetypes, instead doing the mapping directly.
slavapestov
force-pushed
the
pack-expansion-closures-part-4
branch
from
8e5d947 to
7e36060
Compare
slavapestov
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #73393. This cleans up some logic for variables inside pack iteration for loops in preparation for variables whose types contain element archetypes becoming a more general thing.