Pack expansion closures, part 5 #73685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pWithCapturedEnvironments()
…nresolved local archetypes We maintained a counter of the number of pending local archetypes that had not yet been defined. However, if an instruction that references a pending local archetype was deleted before the local archetype was defined, the counter would never decrement. Before reading the counter value, garbage collect any inserted placeholders that have no uses. These correspond to pending local archetypes that are no longer in use and will never be defined.
slavapestov
force-pushed
the
pack-expansion-closures-part-5
branch
2 times, most recently
from
94b6c66 to
cf27663
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #73570. More plumbing to convert between local and primary archetypes in the various places its needed. There is only one more PR remaining after this, which lands the SILGen local archetype transform, as well as end-to-end tests for all of this.