-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Pack expansion closures, part 6 #73712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slavapestov
merged 8 commits into
swiftlang:main
from
slavapestov:pack-expansion-closures-part-6
May 18, 2024
Merged
Pack expansion closures, part 6 #73712
slavapestov
merged 8 commits into
swiftlang:main
from
slavapestov:pack-expansion-closures-part-6
May 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8631a24
to
4a5e905
Compare
Just to be extra safe, I'm only going to call this when captured local archetypes are present.
…clRefs The main entry point _does_ have a generic signature, it's just empty.
0c5ef74
to
1368bc9
Compare
@swift-ci Please smoke test |
Looks like this also resolves #73551 🙂 |
…losure The generic environment introduced by a `for .. in` statement remains in scope until the end of the statement. Copy and paste (ugh) the book-keeping from ASTVerifier for this.
This implements support for autoclosures, closures and local functions nested within a pack iteration for loop. The combination of explicit closure expressions and pack expansion expressions still needs some work. Fixes swiftlang#66917. Fixes swiftlang#69947. Fixes rdar://113505724. Fixes rdar://122293832. Fixes rdar://124329076.
1368bc9
to
4aa0008
Compare
@swift-ci Please test |
@swift-ci Please test source compatibility |
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #73685.
This implements support for autoclosures, closures and local functions nested within a pack iteration for loop, in what I believe is full generality.
Some combinations of closures also work with pack expansion expressions, but not all; this part needs more work in the solver.
General idea:
When a closure doesn't capture any local archetypes, the extended generic signature is the same as the original generic signature, and we skip the substitution map transform, etc.
Fixes #66917.
Fixes #69947.
Fixes rdar://113505724.
Fixes rdar://122293832.
Fixes rdar://124329076.