Skip to content

Typed throws ABI revert #76435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 13, 2024
Merged

Typed throws ABI revert #76435

merged 13 commits into from
Sep 13, 2024

Conversation

aschwaighofer
Copy link
Contributor

No description provided.

@aschwaighofer
Revert "Merge pull request swiftlang#76396 from aschwaighofer/async_t…
617a089 
…yped_throws_empty_errors"

This reverts commit ba8b7e4, reversing
changes made to 4693a47.
@aschwaighofer
Revert "Merge pull request swiftlang#76302 from drexin/wip-typed-thro…
55252e5 
…ws-empty"

This reverts commit cf2af68, reversing
changes made to 0c30f55.
@aschwaighofer
Revert "Merge pull request swiftlang#76129 from aschwaighofer/irgen_t…
66586a6 
…yped_throws_irgenthunk"

This reverts commit dd0de58, reversing
changes made to 74b3221.
@aschwaighofer
Revert "Merge pull request swiftlang#75677 from drexin/wip-133006541"
291abb6 
This reverts commit 739c719, reversing
changes made to 7d1c505.
@aschwaighofer
Revert "Merge pull request swiftlang#75379 from drexin/wip-132122011"
2bc788c 
This reverts commit 618a9bf, reversing
changes made to 448596c.
@aschwaighofer
Revert "Merge pull request swiftlang#75316 from drexin/wip-131960281"
8be1077 
This reverts commit e3577ed, reversing
changes made to f3acbb0.
@aschwaighofer
Revert "Merge pull request swiftlang#75221 from drexin/wip-129359370"
9bebe11 
This reverts commit c11b301, reversing
changes made to 1921b60.
@aschwaighofer
Revert "Merge pull request swiftlang#75150 from drexin/wip-130971168"
85c5648 
This reverts commit 8fca31e, reversing
changes made to 32af2f6.
@aschwaighofer
Revert "Merge pull request swiftlang#75149 from drexin/wip-ptr-cast-tt"
790c269 
This reverts commit 32af2f6, reversing
changes made to d84a919.
@aschwaighofer
Revert "Merge pull request swiftlang#75072 from drexin/wip-refactor-t…
25bc387 
…e-callemission"

This reverts commit 22b6319, reversing
changes made to 4e4d547.
@aschwaighofer
Revert "Merge pull request swiftlang#74840 from drexin/wip-130781414"
9b10362 
This reverts commit 7feb592, reversing
changes made to 4edda08.
@aschwaighofer
Revert "Merge pull request swiftlang#74839 from drexin/wip-130783369"
7955ba9 
This reverts commit 4edda08, reversing
changes made to ac5763b.
@aschwaighofer
Revert "Merge pull request swiftlang#74192 from drexin/wip-typed-thro…
c9c45a1 
…ws-abi"

This reverts commit 35b2b71, reversing
changes made to c3b57f2.
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@tbkka tbkka requested a review from drexin September 12, 2024 19:13
@tbkka
Copy link
Contributor

tbkka commented Sep 12, 2024

The Typed Throws ABI still has a lot of issues. I agree with reverting it until we can work through those.

@aschwaighofer
Copy link
Contributor Author

The failures on windows seem related to a broken bot -- nothing in this PR touches how we copy an array in the runtime.

Looks like maybe the disk is full or something.

FAIL: Swift-Unit :: runtime/./SwiftRuntimeTests.exe/3/61 (11052 of 11118)
******************** TEST 'Swift-Unit :: runtime/./SwiftRuntimeTests.exe/3/61' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:T:\5\tools\swift\unittests\runtime\.\SwiftRuntimeTests.exe-Swift-Unit-6880-3-61.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=61 GTEST_SHARD_INDEX=3 T:\5\tools\swift\unittests\runtime\.\SwiftRuntimeTests.exe
--

Note: This is test shard 4 of 61.

[==========] Running 1 test from 1 test suite.

[----------] Global test environment set-up.

[----------] 1 test from TestArrayCopy

[ RUN      ] TestArrayCopy.test_swift_arrayInitWithTakeFrontToBackPOD

[       OK ] TestArrayCopy.test_swift_arrayInitWithTakeFrontToBackPOD (0 ms)

[----------] 1 test from TestArrayCopy (0 ms total)



[----------] Global test environment tear-down
Exception Code: 0x80000003

LLVM ERROR: IO failure on output stream: bad file descriptor

drexin
drexin approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@aschwaighofer
Copy link
Contributor Author

@swift-ci test windows

@aschwaighofer aschwaighofer merged commit d4c865c into swiftlang:main Sep 13, 2024
5 checks passed
This was referenced Sep 13, 2024
Merged
Merged
stmontgomery added a commit to swiftlang/swift-testing that referenced this pull request Sep 16, 2024
@stmontgomery
Un-revert "Replace rethrows with typed throws in Graph" (#692)
dcc3a1f 
This un-reverts the changes originally landed in #662. Those changes
were reverted in #679 due to a compiler issue which broke CI builds. We
believe that compiler issue has been resolved via a revert in the Swift
repo, made in swiftlang/swift#76435.

Before landing this (currently draft) PR, I plan to validate that
Swift's CI is no longer affected using a cross-repo CI toolchain build.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drexin drexin drexin approved these changes

@tbkka tbkka tbkka approved these changes

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschwaighofer @tbkka @drexin