Run windows tests directly in same shell #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
force-pushed
the
debug-failing-windows-tests-2
branch
from
994cb4c to
0e0ab77
Compare
plemarquand
changed the title
Occasionally the Windows tests will hang after all tests have completed until the GitHub action times out. Using `Start-Process` with the `-Wait` flag will wait for the process and all of its child processes to terminate. This means that if the VS Code instance under test has any lingering processes the build may hang forever. Instead run the test command directly, referencing the success status with `$LASTEXITCODE`. This should hopefully report the status more reliably without hanging.
plemarquand
force-pushed
the
debug-failing-windows-tests-2
branch
from
0e0ab77 to
9b3b500
Compare
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
rbenegal
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally the Windows tests will hang after all tests have completed until the GitHub action times out. Using
Start-Processwith the-Waitflag will wait for the process and all of its child processes to terminate. This means that if the VS Code instance under test has any lingering processes the build may hang forever.Instead run the test command directly, referencing the success status with
$LASTEXITCODE. This should hopefully report the status more reliably without hanging.