[pull] swiftwasm from apple:master #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
`pathComponents` doesn't help with disambiguation, so it shouldn't be a part of the identifier, but can be moved up one level. Include an interface language in the identifier instead. rdar://problem/58853310
This is in preparation to a change in serialization of global variables where this detail will matter.
Fixes <rdar://58929109> assertion failure - UNREACHABLE executed at swift/include/swift/SIL/OwnershipUtils.h:127!
setPointsToEdge should assert that its target isn't already merged, but now that we batch up multiple merge requests, it's fine to allow the target to be scheduled-for-merge. Many assertions have been recently added and tightened in order to "discover" unexpected cases. There's nothing incorrect about how these cases were handled, but they lack unit tests. In this case I still haven't been able to reduce a test case. I'm continuing to work on it, but don't want to further delay the fix.
Fix propagation of guaranteed phi args during DiagnoseUnreachable.
[Diagnostics] Port invalid conversion to AnyObject diagnostic
* Fix memory leaks in ThreadBarriers.swift * Fatal error on pthread cond/mutex destroy failure * Rename pthread to thread * Fix pthread init function calls * Fix guard statement
Compile libraries in testcases with -parse-as-library (NFC)
Originally type mismatches associated with metatypes were only covered for coercions but fix coverage grew since then and now it makes sense to remove special case and let `repairFailures` take care of it.
This is a follow to #29507 addressing one more place in which we need to collate -F with the framework path Addresses rdar://problem/58934566
This will be critical when OSSA relies on access markers everywhere and more passes are converted to OSSA.
[Incremental] Tests and bug fixes for per-type fingerprints.
[ConstraintSystem] Extend metatype instance type mismatch coverage
…29444) * Add source annotation to SILPrinter under flag -sil-print-sourceinfo rdar://58365252
Make sure we use the sugared form of GenericTypeParamType and not the canonical type. Fixes <rdar://problem/58578998>.
…395-type-fingerprint-test
EscapeAnalysis: add support for access markers.
Sema: Fix module interface printing of inherited generic initializers
…rface-language SymbolGraph: Serialize interface language
…ingerprints in unit tests.
…fault-3 [Incremental: Add a unit test for individual node dependency propagation]
Private method should be for non-Windows only
Fixes <https://bugs.swift.org/browse/SR-11681> / <rdar://problem/56747659>.
…fied requirements The fix for <https://bugs.swift.org/browse/SR-10466> did not handle properties because those types are resolved using the archetype resolver. We would bail out early because of a bogus early return that can just be removed. Fixes <rdar://problem/45271663>.
Sema: Fix duplicate diagnostic spam with 'Self' in properties
Originally type mismatches associated with conversions between function types were only covered for coercions and assignments but fix coverage grew since then and now it makes sense to remove special case and let `repairFailures` take care of it.
…ility with enabled type fingerprints.
… type fingerprints.
…ociated with function result type If there are any requirement failures associated with result types which are part of a function type conversion, let's record general conversion mismatch in order for it to capture and display complete function types.
[CSDiag] Removing unused FailureDiagnosis::visitTryExpr
…hecking-screwup Sema: Fix crash when property type references type alias with unsatisfied requirements
…fault-4 [Incremental] Fix 2 tests to be compatible with type-fingerprints
[ConstraintSystem] Extend function type conversion mismatch coverage
Revert "build: simplify version tracking logic"
Add another cross-cutting module configuration to the nested types table search path. A module can have no overlay but also contain a nested types table suitable for finding a given member name. UIKit is the sharpest example of this state of affairs. UIKit currently defines an overlay in Swift where we find some nested types. But it also defines an inner module that has some other nested types tables. Resolves rdar://58940989
This reverts commit 951b853.
This reverts commit ec70a40.
[NFC] Commit a regression test for rdar://58960414
Revert: [SourceKit] Disable module system headers validation
|
Close until #36 merged |
MaxDesiatov
pushed a commit
that referenced
this pull request
Feb 13, 2020
[pull] swiftwasm from apple:master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )