[pull] swiftwasm from apple:master #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…/closed over parameters.
`pathComponents` doesn't help with disambiguation, so it shouldn't be a part of the identifier, but can be moved up one level. Include an interface language in the identifier instead. rdar://problem/58853310
This is in preparation to a change in serialization of global variables where this detail will matter.
Fixes <rdar://58929109> assertion failure - UNREACHABLE executed at swift/include/swift/SIL/OwnershipUtils.h:127!
setPointsToEdge should assert that its target isn't already merged, but now that we batch up multiple merge requests, it's fine to allow the target to be scheduled-for-merge. Many assertions have been recently added and tightened in order to "discover" unexpected cases. There's nothing incorrect about how these cases were handled, but they lack unit tests. In this case I still haven't been able to reduce a test case. I'm continuing to work on it, but don't want to further delay the fix.
Fix propagation of guaranteed phi args during DiagnoseUnreachable.
[Diagnostics] Port invalid conversion to AnyObject diagnostic
* Fix memory leaks in ThreadBarriers.swift * Fatal error on pthread cond/mutex destroy failure * Rename pthread to thread * Fix pthread init function calls * Fix guard statement
Compile libraries in testcases with -parse-as-library (NFC)
Diagnose an attempt to reference a top-level name shadowed by
a local member e.g.
```swift
extension Sequence {
func test() -> Int {
return max(1, 2)
}
}
```
Here `min` refers to a global function `min<T>(_: T, _: T)` in `Swift`
module and can only be accessed by adding `Swift.` to it, because `Sequence`
has a member named `min` which accepts a single argument.
Stop filtering outer overload choices while trying to pre-check expression, instead have it always fetch those and use new fix to only attempt them in diagnostic mode (unless it's min/max situation with conditional conformances).
Although such functionality is not yet supported we have to mirror AST lookup and add such members into results, otherwise there is a risk of inner/outer results mismatch.
The current way that VarDecl::isLazilyInitializedGlobal() is implemented does not work in the debugger, since the DeclContext of all VarDecls are deserialized Swift modules. By adding a bit to the VarDecl we can recover the fact that a VarDecl was in fact a global even in the debugger. <rdar://problem/58939370>
This is in preparation to a change in serialization of global variables where this detail will matter.
Originally type mismatches associated with metatypes were only covered for coercions but fix coverage grew since then and now it makes sense to remove special case and let `repairFailures` take care of it.
This is a follow to #29507 addressing one more place in which we need to collate -F with the framework path Addresses rdar://problem/58934566
This will be critical when OSSA relies on access markers everywhere and more passes are converted to OSSA.
[Incremental] Tests and bug fixes for per-type fingerprints.
[ConstraintSystem] Extend metatype instance type mismatch coverage
…29444) * Add source annotation to SILPrinter under flag -sil-print-sourceinfo rdar://58365252
…te-run Update tsan-emptyarraystorage.swift to run on remote_run
…B` build With such a build we avoid linking the `clangAST` library.
…2e27efd5b4049e [sil.rst] Clarify documentation around partial_apply closure contexts/closed over parameters.
…wift which replaces the existing module from swift_build_support.
They don't have a context and therefore are not consumed. Fixes a failing assert. rdar://59046275
[Constraint system] Make solver less expression-centric, part N/M
[Diagnostics] Port name shadowing diagnostics
…lyEscaping_c_closure SILGen: Fix withoutActuallyEscaping of 'c' closures
[Build System: build-script] Adds a new cache_utils module to build_swift which replaces the existing module from swift_build_support.
…ault-5 [Incremental] Turn type-body-fingerprints on-by-default
The static variants should use the same flags as the dynamic variants. We missed the name conversion in the variable computation causing the static and dynamic builds to diverge.
The change to introduce a "top-level" bit for VarDecls requires a module format version bump, per #29024. Fixes rdar://problem/59078925
…ersion [Serialization] Bump module format version.
Fixes <rdar://problem/58887618>.
Type checking an expression pattern had a hack to work around some diagnostics issues with conditions. These issues have been addressed by the new diagnostic infrastructure, so remove this unnecessary use of ExprTypeCheckListener and check the expression pattern condition using… typeCheckCondition().
…e solver Rather than use an ExprTypeCheckListener subclass to introduce the autoclosure expression, do it at the end of solving.
…class-methods AST: Fix computeSelfParam() to respect __consuming on class methods
This flag is recoverable from the contextual type purpose; don’t duplicate the logic.
This is always set along with SubExpressionDiagnostics, so use that for both purposes. That flag will go away when `CSDiag.cpp` goes away.
build: correct the handling for the static variants
A contextual type purpose, that is, so it captures more about what the entity is that is being solved.
MaxDesiatov
pushed a commit
that referenced
this pull request
Feb 13, 2020
[pull] swiftwasm from apple:master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )