Skip to content

Upgrade to Symfony 6.0 #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

javiereguiluz
Copy link
Member

No description provided.

@javiereguiluz javiereguiluz mentioned this pull request Dec 2, 2021
@javiereguiluz javiereguiluz force-pushed the update_sf60 branch 4 times, most recently from 8036ce0 to 000f49d Compare December 2, 2021 16:12
@94noni
Copy link
Contributor

94noni commented Dec 4, 2021

Great PR :)
Also it could be great to add in the readme that the demo uses latest symfony version, and also upgrade the php required version mentionned
:)

@javiereguiluz
Copy link
Member Author

@stof what do you propose to fix the bugs reported by the "Lint / Linters (8.0)" GitHub action?

  • Ignore them in this PR, but fix them in a separate PR before the next stable release (the first one compatible with 6.0)
  • Ignore them and release the next stable release without fixing them (fix them in the future)
  • Fix them in this PR
  • Tweak the PHPStan config to remove most of these "bugs"
  • other?

Thanks!

@stof
Copy link
Member

stof commented Dec 7, 2021

Most of the errors have 2 sources:

  • Symfony 6 provides more precise return types, which means that some baseline errors have disappeared entirely
  • the CI now runs phpstan 1, which changed some error message (talking about type rather than typehint) meaning the baseline does not match anymore

In both cases, the fix for this PR is the same: running phpstan analyze --generate-baseline to regenerate the baseline and commit the new phpstan-baseline.neon file.

@stof
Copy link
Member

stof commented Dec 7, 2021

btw, phpstan should be installed through require-dev instead of relying on a global install in github actions, so that the second point (changes due to changing the version of phpstan) only happens when actually updating the phpstan dependency.

@javiereguiluz
Copy link
Member Author

Christophe, I've done what you proposed ... and it worked like a charm 😍 Thanks a lot! I think this PR is now ready.

@javiereguiluz javiereguiluz merged commit 287057c into symfony:main Dec 9, 2021
@javiereguiluz javiereguiluz deleted the update_sf60 branch May 5, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants