Skip to content

Assets manifest is not necessary with Webpack Encore #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 3, 2021

Fix breaking changes introduced by #1278

Asset urls generated in entrypoints.json

"/build/app.ac992678.css"
are not meant to be mapped with manifest.json
"build/app.css": "/build/app.ac992678.css",

The only place where the twig asset function is used, is for a file that is not in the manifest:

<link rel="icon" type="image/x-icon" href="{{ asset('favicon.ico') }}" />

@javiereguiluz
Copy link
Member

Thank you Jérôme.

@javiereguiluz javiereguiluz merged commit c2315f7 into symfony:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants