Enable strict mode on assets #1278
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea! Thanks Jérôme. |
|
@GromNaN I'm seeing this error after merging this PR. Am I doing something wrong?
If I uncomment this option, the app works again 🤔 |
|
Oups, I should have tested locally first. I was expecting the CI to fail if there was an error. I check. |
|
The manifest is not necessary. The whole framework:
assets:
base_path: '/' |
|
Yes, this fixed the problem for me. See a118c41 Thanks! |
|
@javiereguiluz |
|
The |
javiereguiluz
added a commit
that referenced
this pull request
Dec 7, 2021
This PR was merged into the main branch. Discussion ---------- Assets manifest is not necessary with Webpack Encore Fix breaking changes introduced by #1278 Asset urls generated in `entrypoints.json` https://github.com/symfony/demo/blob/a7a975e2938b0568b493406ce914ac0866b6dd58/public/build/entrypoints.json#L13 are not meant to be mapped with `manifest.json` https://github.com/symfony/demo/blob/a7a975e2938b0568b493406ce914ac0866b6dd58/public/build/manifest.json#L2 The only place where the twig `asset` function is used, is for a file that is not in the manifest: https://github.com/symfony/demo/blob/a7a975e2938b0568b493406ce914ac0866b6dd58/templates/base.html.twig#L17 Commits ------- 8e9facc Assets manifest is not necessary with Webpack Encore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://symfony.com/blog/new-in-symfony-5-4-misc-features-part-1#strict-mode-for-missing-assets