-
-
Notifications
You must be signed in to change notification settings - Fork 495
move doctrine migrations away from src #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm already doing this for all of my projects. So 👍 from me. |
alternatively to introduce a more generic/reusable directory in our landscape: We should carefully think about root directories though, at some point it gets out of control. |
The more generic/reusable proposition was made a long-time ago, but without enough traction/consensus to happen: a
|
i like |
I like |
@javiereguiluz ive reread the issue real quick, fair enough :) the ship has sailed. I still think it's more concise in general, but 👍 for many root dirs tied to SF, in a SF specific project dir. |
Also related discussion: https://github.com/doctrine/DoctrineMigrationsBundle/pull/295/files#r362401350 |
This PR was merged into the master branch. Discussion ---------- Move doctrine migrations away from src Related to symfony/recipes#718 Commits ------- 10d3324 Move doctrine migrations away from src
This PR was merged into the master branch. Discussion ---------- Move doctrine migrations away from src Related to symfony/recipes#718 Commits ------- 10d3324 Move doctrine migrations away from src
This PR was merged into the master branch. Discussion ---------- Move doctrine migrations away from src Related to symfony/recipes#718 Commits ------- 10d3324 Move doctrine migrations away from src
it was briefly discussed here #172 (comment), but seems to be ignored eventually
i like to propose to move
src/Migrations
tomigrations/
. I dont understand why we are moving mountains to keep it in src (extra config etc.) :/ is there any technical blocker to not move it away from src?semantically it does not belong in src IMHO.
(https://www.tomasvotruba.cz/blog/2019/12/23/5-things-i-improve-when-i-get-to-new-repository/#3-move-code-to-src)
The text was updated successfully, but these errors were encountered: