Skip to content

Recipe for upcoming doctrine/migrations 3.0 and 2.2 #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Mar 28, 2020
Merged

Recipe for upcoming doctrine/migrations 3.0 and 2.2 #729

1 commit merged into from
Mar 28, 2020

Conversation

goetas
Copy link
Contributor

@goetas goetas commented Jan 30, 2020 •
edited
Loading

Q A
License MIT
Doc issue/PR -

Closes #718

ghost
ghost suggested changes Jan 30, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@nicolas-grekas
Copy link
Member

Hello, how can we move forward here?
Creating a new SF5.1 website-skeleton fails currently because this patch (or a similar one) is missing.
Sorry, I'm not deep enough into the topic to be helpful here...

@goetas
Copy link
Contributor Author

goetas commented Mar 15, 2020

The reason why is failing is related to symfony/orm-pack#18 and symfony/orm-pack#22

@goetas
Copy link
Contributor Author

goetas commented Mar 15, 2020

Orm pack should have a major release each time a major release is merged into doctrine

@goetas
Copy link
Contributor Author

goetas commented Mar 15, 2020 •
edited
Loading

As a quick solution you can revert symfony/orm-pack#22 and later address some of the concerns I've expressed into my comments

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 15, 2020 •
edited
Loading

The reason is that I installed doctrine/doctrine-migrations-bundle v3 :)
The pack is just ... a pack

@goetas
Copy link
Contributor Author

goetas commented Mar 15, 2020 •
edited
Loading

The reason is that I installed doctrine/doctrine-migrations-bundle v3 :)
The pack is just ... a pack

Ah... my bad. 👍

doctrine/doctrine-migrations-bundle v3 is not yet released, so some error can still happen

@goetas goetas force-pushed the doctine-migrations-3.0 branch from 8373785 to 7f17c48 Compare March 16, 2020 08:17
ghost
ghost approved these changes Mar 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@goetas
Copy link
Contributor Author

goetas commented Mar 16, 2020

applied proposal in #718, now migrations are in root migrations

@goetas goetas marked this pull request as ready for review March 16, 2020 08:20
ghost
ghost approved these changes Mar 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas
Copy link
Member

@goetas do you consider it still WIP? If not can you please update the PR title. to confirm?

@goetas goetas force-pushed the doctine-migrations-3.0 branch from 7f17c48 to d64c7f7 Compare March 22, 2020 11:11
ghost
ghost suggested changes Mar 22, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@goetas goetas force-pushed the doctine-migrations-3.0 branch from d64c7f7 to 4bea6a9 Compare March 28, 2020 09:40
ghost
ghost approved these changes Mar 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@goetas goetas changed the title [WIP] Doctrine migrations 3.0 recipe Recipe for upcoming doctrine/migrations 3.0 and 2.2 Mar 28, 2020
ghost
ghost approved these changes Mar 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@goetas
Copy link
Contributor Author

goetas commented Mar 28, 2020

@nicolas-grekas this is ready

@goetas
Copy link
Contributor Author

goetas commented Mar 28, 2020

What are the next steps to see this merged?

ghost
ghost approved these changes Mar 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 5bdd246 into symfony:master Mar 28, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 14, 2020
Closed
@GPHemsley
Copy link

It looks like the recipe for 3.0 didn't actually make it into this PR? https://github.com/doctrine/DoctrineMigrationsBundle/blob/3.0.x/UPGRADE.md reports changes that are not covered here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@BoShurik BoShurik BoShurik left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move doctrine migrations away from src
6 participants
@goetas @nicolas-grekas @GPHemsley @OskarStark @BoShurik @chalasr