-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong entry in development documentation and other minor documentation corrections. #8661
Conversation
2798bd7
to
497bc61
Compare
Change the docker registry entry for KO to `localhost:5000`. The former entry `kind.local` lead to an error when deploying the local pipeline build. Fix a broken link in the testing documentation and remove a leftover comment from the makefile which was targeted to a non existing configuration. Add optional installation recommendation for `yamllint` so that it can be used when running `pre-commit` locally otherwise it will show a `Failed` message when linting yaml files. Issue tektoncd#8660 Issue tektoncd#8486 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
497bc61
to
e914d46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@twoGiants Thanks for this! About the |
Thanks, I removed the "documentation" label.
Yes, I created a small issue #8660. The error is:
I am investigating a bit further. I will get back at you here. |
@afrittoli I found the issue with But when I start the kind cluster without the local registry Thanks for pointing that out @afrittoli, it helped me to dig a bit deeper and find the real issue! |
@afrittoli updated the documentation in this tiny PR #8662. Thank you for the review! |
Changes
Change the docker registry entry for
KO_DOCKER_REPO
tolocalhost:5000
. The former entrykind.local
(here) lead to an error when deploying the local pipeline build.Fix a broken link in the testing documentation and remove a leftover comment from the makefile which was targeted to a non existing configuration.
Add optional installation recommendation for
yamllint
so that it can be used when runningpre-commit
locally otherwise it will show aFailed
message when linting yaml files.Closes #8660
Closes #8486
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes