Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong entry in development documentation and other minor documentation corrections. #8661

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ You must install these tools:

1. [`go-licenses`](https://github.com/google/go-licenses) is used in e2e tests.

1. (Optional)
[`yamllint`](https://github.com/adrienverge/yamllint?tab=readme-ov-file#installation)
is run against every PR as part of `pre-commit`. You may want to install this tool
so that `pre-commit` can use it, otherwise it will show a `failed` message for
when linting yaml files.

1. (Optional)
[`golangci-lint`](https://golangci-lint.run/welcome/install/#local-installation)
is run against every PR. You may want to install and [run this tool
Expand Down Expand Up @@ -303,7 +309,7 @@ The recommended minimum development configuration is:
4. Configure [ko](https://kind.sigs.k8s.io/):

```sh
$ export KO_DOCKER_REPO="kind.local"
$ export KO_DOCKER_REPO="localhost:5000"
$ export KIND_CLUSTER_NAME="kind" # only needed if you used a custom name in the previous step
```

Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ TESTPKGS = $(shell env GO111MODULE=on $(GO) list -f \
BIN = $(CURDIR)/.bin
WOKE ?= go run -modfile go.mod github.com/get-woke/woke

# Get golangci_version from tools/go.mod
GOLANGCI_VERSION := $(shell yq '.jobs.linting.steps[] | select(.name == "golangci-lint") | .with.version' .github/workflows/ci.yaml)
WOKE_VERSION = v0.19.0

Expand Down
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ via the sections for `tektoncd/pipeline`.

The presubmit integration tests entrypoint will run:

- [The integration tests](#integration-tests)
- [The integration tests](#end-to-end-tests)
- A test of [our example CRDs](../examples/README.md#testing-the-examples)

When run using Prow, integration tests will try to get a new cluster using
Expand Down
Loading