Updates references to numpy deprecated type aliases. #6140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022. Without this change, our build would be broken when using numpy version >= 1.24.0, with error "AttributeError: module 'numpy' has no attribute 'float'". The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply `float`.) [1] numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated [2] numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations
nfelt
approved these changes
Jan 12, 2023
arcra
added a commit
to arcra/tensorboard
that referenced
this pull request
Jan 12, 2023
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022. Without this change, our build would be broken when using numpy version >= 1.24.0, with error `AttributeError: module 'numpy' has no attribute 'float'`. The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply `float`.) [1] http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated [2] http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations * Motivation for features / changes Newer numpy versions break our build. This code is exactly equivalent, as the identifiers used previously were aliases for the same type. * Technical description of changes Replace occurrences of `np.float` for the primitive type `float`. * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) Ran tests. * Alternate designs / implementations considered N/A. (cherry picked from commit 7bcc5e8)
Merged
arcra
added a commit
to arcra/tensorboard
that referenced
this pull request
Jan 12, 2023
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022. Without this change, our build would be broken when using numpy version >= 1.24.0, with error `AttributeError: module 'numpy' has no attribute 'float'`. The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply `float`.) [1] http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated [2] http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations * Motivation for features / changes Newer numpy versions break our build. This code is exactly equivalent, as the identifiers used previously were aliases for the same type. * Technical description of changes Replace occurrences of `np.float` for the primitive type `float`. * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) Ran tests. * Alternate designs / implementations considered N/A. (cherry picked from commit 7bcc5e8)
arcra
added a commit
that referenced
this pull request
Jan 13, 2023
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022. Without this change, our build would be broken when using numpy version >= 1.24.0, with error `AttributeError: module 'numpy' has no attribute 'float'`. The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply `float`.) [1] http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated [2] http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations * Motivation for features / changes Newer numpy versions break our build. This code is exactly equivalent, as the identifiers used previously were aliases for the same type. * Technical description of changes Replace occurrences of `np.float` for the primitive type `float`. * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) Ran tests. * Alternate designs / implementations considered N/A. (cherry picked from commit 7bcc5e8)
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022. Without this change, our build would be broken when using numpy version >= 1.24.0, with error `AttributeError: module 'numpy' has no attribute 'float'`. The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply `float`.) [1] http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated [2] http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations * Motivation for features / changes Newer numpy versions break our build. This code is exactly equivalent, as the identifiers used previously were aliases for the same type. * Technical description of changes Replace occurrences of `np.float` for the primitive type `float`. * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) Ran tests. * Alternate designs / implementations considered N/A.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022. Without this change, our build would be broken when using numpy version >= 1.24.0, with error `AttributeError: module 'numpy' has no attribute 'float'`. The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply `float`.) [1] http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated [2] http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations * Motivation for features / changes Newer numpy versions break our build. This code is exactly equivalent, as the identifiers used previously were aliases for the same type. * Technical description of changes Replace occurrences of `np.float` for the primitive type `float`. * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) Ran tests. * Alternate designs / implementations considered N/A.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022.
Without this change, our build would be broken when using numpy version >= 1.24.0,
with error
AttributeError: module 'numpy' has no attribute 'float'.The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply
float.)[1] http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated
[2] http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations
Motivation for features / changes
Newer numpy versions break our build. This code is exactly equivalent, as the identifiers used previously were aliases for the same type.
Technical description of changes
Replace occurrences of
np.floatfor the primitive typefloat.Screenshots of UI changes
N/A
Detailed steps to verify changes work correctly (as executed by you)
Ran tests.
Alternate designs / implementations considered
N/A.