TensorBoard 2.11.1 #6141
Merged
TensorBoard 2.11.1 #6141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`numpy.bool8` is just a deprecated alias of [`numpy.bool_`](https://numpy.org/doc/stable/reference/arrays.scalars.html#numpy.bool_). Removed here to get rid of the deprecation warnings (tensorflow#6110). Googlers, see cl/498031924 for internal tests. #oncall (cherry picked from commit 2bfdca4)
Numpy library deprecated some type aliases in version 1.20.0 [1], and then removed them in version 1.24.0 [2], which was released on Dec 18, 2022. Without this change, our build would be broken when using numpy version >= 1.24.0, with error `AttributeError: module 'numpy' has no attribute 'float'`. The fix suggested in release notes from numpy version 1.20.0 is to replace these types with the equivalent primitive python types. (In this case, simply `float`.) [1] http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated [2] http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations * Motivation for features / changes Newer numpy versions break our build. This code is exactly equivalent, as the identifiers used previously were aliases for the same type. * Technical description of changes Replace occurrences of `np.float` for the primitive type `float`. * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) Ran tests. * Alternate designs / implementations considered N/A. (cherry picked from commit 7bcc5e8)
…auth flow. (tensorflow#6107) * Motivation for features / changes The OOB auth flow has been deprecated. We concluded that the limited-input device flow is appropriate for our use case where the uploader runs in an environment where a browser is not available. * Technical description of changes Implements a new auth flow which calls an RPC to fetch a device_code, verification_url and user_code, and asks user to visit the verification_url in another device and enter the user_code; then starts polling for the access token after the user authorizes the access from another device. * Screenshots of UI changes N/A * Detailed steps to verify changes work correctly (as executed by you) - Wrote test script that uses this class, and tested the auth flow and was able to print the credentials. - Wrote tests. * Alternate designs / implementations considered Basically, implementing something similar to this flow or the OOB flow ourselves. (cherry picked from commit 8da06b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch release to replace the deprecated OOB auth flow, and remove deprecated aliases
that were removed in numpy 1.24.0.
Bug fixes
numpy.bool8#6117, Updates references to numpy deprecated type aliases. #6140)