Skip to content

TensorBoard 2.13.0 #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2023
Merged

TensorBoard 2.13.0 #6365

merged 4 commits into from
May 4, 2023

Conversation

rileyajones
Copy link
Contributor

@rileyajones rileyajones commented May 3, 2023

Motivation for features / changes

The TensorBoard release that tracks the TF 2.13 release.

Technical description of changes

  • Update TensorFlow protos as part of the 2.13 release.
  • Pin the TF version for CI (to tf-nightly=2.13.0.dev20230501)

The proto updates were made by manually copying and editing the new file then updating the remaining files according to these intructions

@rileyajones rileyajones requested a review from arcra May 3, 2023 21:11
@rileyajones rileyajones marked this pull request as ready for review May 3, 2023 22:11
@@ -15,7 +15,7 @@

"""Contains the version string."""

VERSION = "2.13.0a0"
VERSION = "2.13.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want each of these changes to be separate commits in the history of the release, that's why our release guide mentions that if they're all submitted in a single PR, we should use "rebase and merge" (referring to the fact that we would have multiple commits in the same PR).

See example from a previous release: https://github.com/tensorflow/tensorboard/pull/6192/commits

So we should have a commit with only the proto changes, and separate commits for the other steps of the release process.

Also, we will probably want these proto changes in the master branch, so you can choose to either submit those changes in master, and then create this branch again, or later cherry-pick those changes into master as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about the convention of doing this all as a single PR with multiple ordered commits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed the docs are not clear about that. They currently say:

"You may choose to send all of these changes in a single PR, in which case you should rebase and merge after approval."

But perhaps that should be reworded to something like:

"You may choose to send all of these changes as multiple commits (one commit per change) in a single PR, in which case you should rebase and merge after approval."

And then some of the items listed below that paragraph could start with "A commit that ..."

@rileyajones rileyajones changed the title Update tensorflow protos and pinned ci version TensorBoard 2.13 May 4, 2023
@rileyajones rileyajones requested a review from arcra May 4, 2023 18:00
Copy link
Member

@arcra arcra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the "patch" version to the PR title? "Tensorboard 2.13.0"

@rileyajones rileyajones changed the title TensorBoard 2.13 TensorBoard 2.13.0 May 4, 2023
@rileyajones rileyajones merged commit 9826b1b into tensorflow:2.13 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants