-
Notifications
You must be signed in to change notification settings - Fork 1.7k
TensorBoard 2.13.0 #6365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
TensorBoard 2.13.0 #6365
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
syntax = "proto3"; | ||
|
||
package tensorboard; | ||
|
||
option cc_enable_arenas = true; | ||
option java_outer_classname = "GraphDebugInfoProtos"; | ||
option java_multiple_files = true; | ||
option java_package = "org.tensorflow.framework"; | ||
option go_package = "github.com/tensorflow/tensorflow/tensorflow/go/core/protobuf/for_core_protos_go_proto"; | ||
|
||
message GraphDebugInfo { | ||
// This represents a file/line location in the source code. | ||
message FileLineCol { | ||
// File name index, which can be used to retrieve the file name string from | ||
// `files`. The value should be between 0 and (len(files)-1) | ||
int32 file_index = 1; | ||
|
||
// Line number in the file. | ||
int32 line = 2; | ||
|
||
// Col number in the file line. | ||
int32 col = 3; | ||
|
||
// Name of function contains the file line. | ||
string func = 4; | ||
|
||
// Source code contained in this file line. | ||
string code = 5; | ||
} | ||
|
||
// This represents a stack trace which is a ordered list of `FileLineCol`. | ||
message StackTrace { | ||
// Each line in the stack trace. | ||
repeated FileLineCol file_line_cols = 1; | ||
} | ||
|
||
// This stores all the source code file names and can be indexed by the | ||
// `file_index`. | ||
repeated string files = 1; | ||
|
||
// This maps a node name to a stack trace in the source code. | ||
// The map key is a mangling of the containing function and op name with | ||
// syntax: | ||
// op.name '@' func_name | ||
// For ops in the top-level graph, the func_name is the empty string. | ||
// Note that op names are restricted to a small number of characters which | ||
// exclude '@', making it impossible to collide keys of this form. Function | ||
// names accept a much wider set of characters. | ||
// It would be preferable to avoid mangling and use a tuple key of (op.name, | ||
// func_name), but this is not supported with protocol buffers. | ||
map<string, StackTrace> traces = 2; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want each of these changes to be separate commits in the history of the release, that's why our release guide mentions that if they're all submitted in a single PR, we should use "rebase and merge" (referring to the fact that we would have multiple commits in the same PR).
See example from a previous release: https://github.com/tensorflow/tensorboard/pull/6192/commits
So we should have a commit with only the proto changes, and separate commits for the other steps of the release process.
Also, we will probably want these proto changes in the master branch, so you can choose to either submit those changes in master, and then create this branch again, or later cherry-pick those changes into master as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about the convention of doing this all as a single PR with multiple ordered commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed the docs are not clear about that. They currently say:
"You may choose to send all of these changes in a single PR, in which case you should rebase and merge after approval."
But perhaps that should be reworded to something like:
"You may choose to send all of these changes as multiple commits (one commit per change) in a single PR, in which case you should rebase and merge after approval."
And then some of the items listed below that paragraph could start with "A commit that ..."