Fix: trigger queue updates

[ericallam]

Summary by CodeRabbit

• New Features

  • Introduced a new task handling method with a retry mechanism.
  • Added functionality to dynamically adjust task queue concurrency limits.

• Improvements

  • Streamlined task run completion process by removing unnecessary transactional overhead.
  • Enhanced clarity and efficiency in task queue management logic.

• Bug Fixes

  • Maintained existing logic for handling successful and failed task attempts, ensuring proper retry behavior.

• Documentation

  • Updated method signatures to reflect changes in task handling and input types.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 33f169b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant changes to three main files: completeAttempt.server.ts, triggerTask.server.ts, and batch.ts. The CompleteAttemptService class has had its transaction handling simplified, removing unnecessary transactional contexts during task run completions. The TriggerTaskService class has been updated to improve task queue concurrency management, including dynamic updates to concurrency limits. Lastly, the batchChildTask function's parameter type has been broadened, and a new function, batchParentWitFailsTask, has been added to handle retries.

Changes

File Path	Change Summary
apps/webapp/app/v3/services/completeAttempt.server.ts	- Modified CompleteAttemptService to simplify task run completion by removing transaction handling. - Updated method signatures for call, #completeAttemptSuccessfully, and #completeAttemptFailed.
apps/webapp/app/v3/services/triggerTask.server.ts	- Enhanced TriggerTaskService to manage task queue concurrency limits, including dynamic updates. - Streamlined task queue creation logic.
references/v3-catalog/src/trigger/batch.ts	- Updated batchChildTask function to accept any type for payload. - Added new function batchParentWitFailsTask with a retry mechanism.

Possibly related PRs

• Adding missing task run hierarchy to TaskRun table #1332: Changes in ApiRetrieveRunPresenter relate to CompleteAttemptService, enhancing task run data management.
• Run page links to tasks & replay run modal improvements #1364: Enhancements to the run inspector may connect with CompleteAttemptService for task run completion processes.
• fix: cleanup ttl expire run graphile jobs #1373: Modifications in CreateTaskRunAttemptService may connect with CompleteAttemptService regarding task run management.
• Prioritize finishing waited runs #1375: Improvements in handling resumed runs align with changes in CompleteAttemptService for task management.
• Add max queue depth limits #1376: Introduction of queue depth limits relates to task run management in CompleteAttemptService.
• Fix several restore and resume bugs #1418: Fixes for restoring and resuming processes may connect with CompleteAttemptService completion logic.
• fix: removing schedule instance no longer crashes #1430: Improvements to prevent crashes during schedule instance deletions may relate to task run stability in CompleteAttemptService.

🐇 "In the meadow where tasks run free,
A service now dances, as light as can be.
With queues that adjust and retries that play,
Completion is simpler, come hop, come sway!
No more transactions to weigh us down,
Just joyful task runs in our little town!" 🐇

Warning

Rate limit exceeded

@ericallam has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e7fc592 and 33f169b.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint (1.23.1)

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/webapp/app/v3/services/completeAttempt.server.ts

(node:3441) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
(Use node --trace-warnings ... to show where the warning was created)

Oops! Something went wrong! :(

ESLint: 9.15.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

@trigger.dev/core

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1491

@trigger.dev/rsc

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/rsc@1491

@trigger.dev/sdk

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1491

@trigger.dev/react-hooks

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1491

@trigger.dev/build

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1491

trigger.dev

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1491

commit: 33f169b