Skip to content

FAI-841: Python benchmarks failing since namespace migration #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 16, 2022

Conversation

ruivieira
Copy link
Member

@ruivieira ruivieira commented Oct 4, 2022

  • Fixes benchmark GHA to run on correct branches
  • Benchmarks now use new Java namespaces and shaded JAR

Benchmarks on PRs temporarily disabled until Job summaries are implemented by the GH action.

@ruivieira ruivieira added the kind/bug Something isn't working label Oct 4, 2022
@ruivieira ruivieira self-assigned this Oct 4, 2022
@ruivieira ruivieira marked this pull request as draft November 16, 2022 11:24
@ruivieira ruivieira marked this pull request as ready for review November 16, 2022 13:24
Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@RobGeada RobGeada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruivieira ruivieira merged commit f84885a into trustyai-explainability:main Nov 16, 2022
RobGeada pushed a commit that referenced this pull request Nov 22, 2022
* Update benchmarks for new namespace

* Update Maven version on GHA

* Update GHA branch rules

* Update PR benchmark action

* Fix build Arrow converter action name

* Remove file saving from PR benchmarks

* Add skip fetching GH pages

* Remove PR config
@ruivieira ruivieira deleted the FAI-841 branch December 9, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working pipeline
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants