Skip to content

FAI-841: Python benchmarks failing since namespace migration #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .github/workflows/benchmarks-merge.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: TrustyAI Python benchmarks
name: TrustyAI Python benchmarks (merge)

on:
push:
branches:
- 'main'
pull_request:
- main


permissions:
contents: write
Expand All @@ -14,6 +14,7 @@ permissions:

jobs:
benchmark:
if: github.event.pull_request.merged == 'true'
name: Run pytest-benchmark benchmark
runs-on: ubuntu-latest
steps:
Expand All @@ -28,11 +29,13 @@ jobs:
check-latest: true
- uses: stCarolas/setup-maven@v4
with:
maven-version: 3.5.4
- name: Install dependencies
maven-version: 3.8.1
- name: Build explainability-core
uses: ./.github/actions/build-core
- name: Build arrow-converter
uses: ./.github/actions/build-arrow
- name: Install TrustyAI Python package
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -r requirements-dev.txt
pip install .
- name: Run benchmark
Expand Down
27 changes: 11 additions & 16 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: TrustyAI Python benchmarks
name: TrustyAI Python benchmarks (PR)

on:
push:
branches:
- '*'
- '!main'
pull_request:
branches:
- main

permissions:
contents: write
Expand All @@ -29,27 +27,24 @@ jobs:
check-latest: true
- uses: stCarolas/setup-maven@v4
with:
maven-version: 3.5.4
- name: Install dependencies
maven-version: 3.8.1
- name: Build explainability-core
uses: ./.github/actions/build-core
- name: Build arrow-converter
uses: ./.github/actions/build-arrow
- name: Install TrustyAI Python package
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -r requirements-dev.txt
pip install .
- name: Run benchmark
run: |
pytest tests/benchmarks/benchmark.py --benchmark-json tests/benchmarks/results.json
- name: Store benchmark result
- name: Benchmark result comment
uses: benchmark-action/github-action-benchmark@v1
with:
name: TrustyAI continuous benchmarks
tool: 'pytest'
output-file-path: tests/benchmarks/results.json
github-token: ${{ secrets.GITHUB_TOKEN }}
auto-push: false
alert-threshold: '200%'
comment-on-alert: true
comment-always: true
fail-on-alert: false
save-data-file: false
alert-comment-cc-users: '@ruivieira'
alert-comment-cc-users: '@ruivieira'