Skip to content

feat(templates): support nested templates to create nested routes #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

philnash
Copy link
Contributor

Fixes #122

This adds a directory property to TemplateFileInfo and then uses that to place the files in the correct nested directories.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash requested a review from dkundel March 30, 2020 22:35
@philnash philnash changed the title Support nested templates to create nested routes. feat(templates): support nested templates to create nested routes Mar 30, 2020
@philnash
Copy link
Contributor Author

The Pika CI check seems to need a package-lock.json or npm-shrinkwrap.json. But as a package, we shouldn't be checking that in (and it was removed in PR #118). Can we remove the Pika CI check @dkundel?

@dkundel
Copy link
Contributor

dkundel commented Mar 31, 2020

Yeah I'll remove it. Not sure why it requires it :( maybe for performance reasons. I'll review the PR in a few

@dkundel dkundel merged commit 773d073 into twilio-labs:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested templates to create nested routes
2 participants