Skip to content

fix(templates): adds tests for getFiles and replaces Array.flat #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

philnash
Copy link
Contributor

@philnash philnash commented Apr 7, 2020

#123 broke support in Node < 11 due to using Array#flat 🤦‍♂️

This adds tests to ensure the getFiles function works properly and replaces Array#flat with lodash.flatten.

Fixes #124.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash requested a review from dkundel April 7, 2020 01:42
Copy link
Contributor

@dkundel dkundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Super nit pick: the URLs you use in the test are inconsistent between using twilio-labs and philnash. But otherwise this looks good. Thanks for the quick fix. Can you squash and release a new version?

@philnash philnash merged commit abd9f43 into twilio-labs:master Apr 7, 2020
@philnash
Copy link
Contributor Author

philnash commented Apr 7, 2020

Squashed and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add support for Node 10
2 participants