Accept StrPromise as Validator.message and missing_message
#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
May 28, 2024
intgr
requested changes
May 28, 2024
| @@ -2,6 +2,7 @@ from collections.abc import Callable, Container, Iterable, MutableMapping | |||
| from typing import Any, Protocol, TypeVar | |||
|
|
|||
| from django.db.models import Model, QuerySet | |||
| from django.utils.functional import _StrOrPromise | |||
There was a problem hiding this comment.
Use from django_stubs_ext import StrOrPromise, which is public API.
There was a problem hiding this comment.
I checked django-stubs for that, and there are no imports of StrOrPromise from django_stubs_ext.
There was a problem hiding this comment.
Yeah, that's internal to django-stubs. Other projects should import from django_stubs_ext
intgr
changed the title
StrPromise as Validator.message and missing_message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
https://github.com/encode/django-rest-framework/blob/master/rest_framework/validators.py
Related issues