Skip to content

Cleanup: Import StrOrPromise from django_stubs_ext #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

Cleanup: Import StrOrPromise from django_stubs_ext #621

merged 2 commits into from
May 28, 2024

Conversation

q0w
Copy link
Contributor

@q0w q0w commented May 28, 2024

I have made things!

Maybe django_stubs_ext should be explicitly added here as a dependency?

Related issues

#618 (comment)

@intgr intgr changed the title Import StrOrPromise from django_stubs_ext Cleanup: Import StrOrPromise from django_stubs_ext May 28, 2024
intgr
intgr approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

Maybe django_stubs_ext should be explicitly added here as a dependency?

I discussed this with sobolevn in a PR some time ago and thought it's unnecessary; we can rely on the transitive dependency via django-stubs.

@intgr intgr merged commit 960ba09 into typeddjango:master May 28, 2024
12 checks passed
@q0w q0w deleted the patch-1 branch May 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q0w @intgr