Skip to content

Support S3 Sharded loading with RunAI Model Streamer #16317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

omer-dayan
Copy link
Contributor

@omer-dayan omer-dayan commented Apr 9, 2025

In this PR we add support for using RunAI Model Streamer with sharded model files.

It allows the user to upload the sharded model files to S3:
image

and run this model using the following command:
vllm serve s3://core-llm/Llama-3-8b-4/ --tensor-parallel-size 4 --load-format runai_streamer_sharded

Copy link

github-actions bot commented Apr 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@omer-dayan omer-dayan force-pushed the omer/runai-model-streamer-sharded branch from 87ee684 to 31b91c7 Compare April 9, 2025 06:14
@omer-dayan omer-dayan changed the title Support Sharded loading with RunAI Model Streamer Support S3 Sharded loading with RunAI Model Streamer Apr 9, 2025
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Omer Dayan (SW-GPU) <[email protected]>
@omer-dayan omer-dayan force-pushed the omer/runai-model-streamer-sharded branch from cddf0db to 78264e4 Compare April 20, 2025 10:54
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 20, 2025
@DarkLight1337
Copy link
Member

I can't seem to get docker build to pass, can you merge from main again?

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures look unrelated. Thanks for expanding this support!

@vllm-bot vllm-bot merged commit 71ce440 into vllm-project:main Apr 22, 2025
40 of 43 checks passed
dtransposed pushed a commit to dtransposed/vllm that referenced this pull request Apr 22, 2025
)

Signed-off-by: Omer Dayan (SW-GPU) <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
)

Signed-off-by: Omer Dayan (SW-GPU) <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Frieda (Jingying) Huang <[email protected]>
liuzijing2014 pushed a commit to liuzijing2014/vllm that referenced this pull request Apr 25, 2025
)

Signed-off-by: Omer Dayan (SW-GPU) <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Zijing Liu <[email protected]>
liuzijing2014 pushed a commit to liuzijing2014/vllm that referenced this pull request Apr 25, 2025
wuisawesome pushed a commit to character-tech/vllm that referenced this pull request Apr 28, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
)

Signed-off-by: Omer Dayan (SW-GPU) <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
)

Signed-off-by: Omer Dayan (SW-GPU) <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants