Skip to content

[Bugfix] Fix f-string for Python 3.9-3.11 #16962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

[Bugfix] Fix f-string for Python 3.9-3.11 #16962

merged 1 commit into from
Apr 22, 2025

Conversation

DarkLight1337
Copy link
Member

Fix an issue introduced by #16317. The CI still passed for that PR because it's being run in Python 3.12

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 22, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin April 22, 2025 04:38
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@vllm-bot vllm-bot merged commit d6da932 into vllm-project:main Apr 22, 2025
11 of 15 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-fstring branch April 22, 2025 04:45
dtransposed pushed a commit to dtransposed/vllm that referenced this pull request Apr 22, 2025
@DarkLight1337
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
e2ecfd3 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
@DarkLight1337 @frieda-huang
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
31aa76f 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Frieda (Jingying) Huang <[email protected]>
liuzijing2014 pushed a commit to liuzijing2014/vllm that referenced this pull request Apr 25, 2025
@DarkLight1337 @liuzijing2014
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
bd7824e 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Zijing Liu <[email protected]>
liuzijing2014 pushed a commit to liuzijing2014/vllm that referenced this pull request Apr 25, 2025
@DarkLight1337 @liuzijing2014
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
f3df359 
Signed-off-by: DarkLight1337 <[email protected]>
wuisawesome pushed a commit to character-tech/vllm that referenced this pull request Apr 28, 2025
@DarkLight1337 @wuisawesome
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
8eace8b 
Signed-off-by: DarkLight1337 <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @dbyoung18
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
cbe0cdd 
Signed-off-by: DarkLight1337 <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
58a3076 
Signed-off-by: DarkLight1337 <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@DarkLight1337 @adobrzyn
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
a72e737 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Fix f-string for Python 3.9-3.11 (vllm-project#16962)
10f6690 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khluu khluu khluu approved these changes

@mgoin mgoin Awaiting requested review from mgoin

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @khluu @vllm-bot