feat: upgrade to typescript 5 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eslint used in |
This is the minimal upgrade to TypeScript 5. I tried to upgrade only the necessary dependencies and keep the changes to a minimum. Notable changes: - `@vue/tsconfig` upgraded from 0.1.3 to 0.3.0. Note that according to semver, it contains breaking changes. See <https://github.com/vuejs/tsconfig#migrating-from-typescript--50> for more details. - Vite, `vue-tsc`, and Cypress MUST be upgraded to the latest version to support TypeScript 5. - The `tsconfig` files in barebone TypeScript template has been updated. Previously, it was `tsconfig.json` + `tsconfig.node.json`, where `tsconfig.json` contains the configuration for the web app in the `src/` folder and a reference to the `tsconfig.node.json`. Now it is `tsconfig.json` + `tsconfig.app.json` + `tsconfig.node.json`, where `tsconfig.json` contains only references to the other 2 configs. This is to align it with the `tsconfig` files in the other templates, so that users can easily switch between templates. It also avoids some edge cases in solution-style tsconfigs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal upgrade to TypeScript 5.
I tried to upgrade only the necessary dependencies and keep the changes to a minimum.
Notable changes:
@vue/tsconfigupgraded from 0.1.3 to 0.3.2. Note that according to semver, it contains breaking changes. See https://github.com/vuejs/tsconfig#migrating-from-typescript--50 for more details.vue-tsc, and Cypress MUST be upgraded to the latest version to support TypeScript 5.tsconfigfiles in the barebone TypeScript template have been updated.tsconfig.json+tsconfig.node.json, wheretsconfig.jsoncontains the configuration for the web app in thesrc/folder and a reference to thetsconfig.node.json.tsconfig.json+tsconfig.app.json+tsconfig.node.json, wheretsconfig.jsoncontains only references to the other 2 configs.tsconfigfiles in the other templates, so that users can easily switch between templates. It also avoids some edge cases in solution-style tsconfigs.