[New] Add html-closing-bracket-newline (fixes #169)
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
approved these changes
Sep 29, 2017
|
I commented #169 as I'm having little doubts regarding this rule |
|
I updated this PR to solve conflictions. |
michalsnik
changed the title
html-closing-bracket-newline (fixes #169)
michalsnik
approved these changes
Jan 1, 2018
There was a problem hiding this comment.
LGTM 👍 Good job @mysticatea I left just some minor copy suggestions
| } | ||
| ``` | ||
|
|
||
| - `singleline` ... the configuration for single-line elements. It's a single-line element if the element does not have attributes or the last attribute is on the same line of the opening bracket. |
| ``` | ||
|
|
||
| - `singleline` ... the configuration for single-line elements. It's a single-line element if the element does not have attributes or the last attribute is on the same line of the opening bracket. | ||
| - `"never"` ... disallow line breaks before the closing bracket of elements. This is the default. |
|
|
||
| - `singleline` ... the configuration for single-line elements. It's a single-line element if the element does not have attributes or the last attribute is on the same line of the opening bracket. | ||
| - `"never"` ... disallow line breaks before the closing bracket of elements. This is the default. | ||
| - `"always"` ... require one line break before the closing bracket of elements. |
|
I updated this PR. |
michalsnik
approved these changes
Jan 2, 2018
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new rule to enforce the location of closing brackets
>of HTML tags.