New: html-closing-bracket-spacing rule (fixes #229) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
approved these changes
Jan 1, 2018
|
|
||
| - :wrench: The `--fix` option on the [command line](http://eslint.org/docs/user-guide/command-line-interface#fix) can automatically fix some of the problems reported by this rule. | ||
|
|
||
| This rule enforces space style before `>` of tags. |
There was a problem hiding this comment.
This rule enforces consistent spacing style before closing brackets > of elements.
| { | ||
| code: '<template>\n <div >\n </div >\n <div/>\n</template>', | ||
| errors: [ | ||
| { message: "Expected no space before '>', but found.", line: 2 }, |
There was a problem hiding this comment.
It would be also good to check whether column of the > is properly reported.
|
I updated this PR. As a note, this is the range of warnings:
|
|
Brilliant 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229.
This PR adds
vue/html-closing-bracket-spacingrule. This is the spacing style version of #190. It requires or disallows a space before tag's closing brackets.