-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
ci(CircleCI Config): Migrate to CircleCI 2.0 with workflows #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Create CircleCI 2.0 config files with parallelized testing to shorten build and test cycle BREAKING CHANGE: N/A N/A
Thanks for PR, but why is the v2 config file so much more complex? What's the advantage of this over the current shell script? |
Hi, thanks for reviewing! Circle's v2 provides much more customization over v1, and as such requires a lengthier configuration file. The v2 config file in the PR pulls the code, restores and updates the dependency cache, and provides this environment as a common workspace in separate containers for the different types of testing that were present in |
Isn't there a simpler syntax for that. 130 lines of yml config looks like an overkill 😭 |
Unfortunately no, I did the best I could by using references at the top of the yml to avoid repeating many of the lines. I'd be happy to go back in and comment all the things so people can follow along and contribute more easily in the future if that sounds good! |
Add comments to CircleCI 2.0 config.yml BREAKING CHANGE: None N/A
Personally, I think this can save quite some time. Having comments do help. |
asdf BREAKING CHANGE: asdf dsa
asdf BREAKING CHANGE: asdf adsf
asdf BREAKING CHANGE: asfd sadf
I played with this in the CI branch and indeed it greatly speeds up the build, but the base Node image in CircleCI 2 doesn't have java so the Selenium-based e2e tests cannot be run. If anyone wants to take this over and find a suitable docker image to use, contributions are welcome. |
Improves upon vuejs#6041
Improves upon vuejs#6041
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
CircleCI 2.0 allows for faster performance and reduced overall time to build and test by utilizing parallel testing via workflows. The codebase and dependencies are downloaded, cached, and are then used as part of a common workspace for the different components in
npm run test
, which have been split into four parallel containers.Tests should complete in around 1m45s once the initial testing and caching has been done with CircleCI 2.0, compared to around 4m currently.